Upgrade expect-type; fix issues it reveals; add RenderingTestContext #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitKrystan
commented
Dec 14, 2022
| @param {Object} context the context to setup for rendering | ||
| @returns {Promise<Object>} resolves with the context that was setup | ||
| @param {TestContext} context the context to setup for rendering | ||
| @returns {Promise<RenderingTestContext>} resolves with the context that was setup |
There was a problem hiding this comment.
AFAICT no OSS code uses the value here. We could opt not to make it public.
There was a problem hiding this comment.
Seems good to export, actually: it moves us one step closer to not having everything depend on this.<whatever>: even this.element becomes unnecessary if you do this:
import { module, test } from 'qunit';
import { setupRenderingTest } from 'ember-qunit'; // transitively is this
import { render } from '@ember/test-helpers';
module('cool', function (hooks) {
let context = setupRenderingTest(hooks);
test('neato', assert function (assert) {
await render(<template>Hello!</template>);
assert(context.element.innerText.includes("Hello!"));
});
});
chriskrycho
approved these changes
Dec 15, 2022
| @param {Object} context the context to setup for rendering | ||
| @returns {Promise<Object>} resolves with the context that was setup | ||
| @param {TestContext} context the context to setup for rendering | ||
| @returns {Promise<RenderingTestContext>} resolves with the context that was setup |
There was a problem hiding this comment.
Seems good to export, actually: it moves us one step closer to not having everything depend on this.<whatever>: even this.element becomes unnecessary if you do this:
import { module, test } from 'qunit';
import { setupRenderingTest } from 'ember-qunit'; // transitively is this
import { render } from '@ember/test-helpers';
module('cool', function (hooks) {
let context = setupRenderingTest(hooks);
test('neato', assert function (assert) {
await render(<template>Hello!</template>);
assert(context.element.innerText.includes("Hello!"));
});
});
|
This one will also need to have a merge or rebase! |
chriskrycho
changed the title
gitKrystan
force-pushed
the
upgrade-expect-type
branch
from
0c76569
to
3f42108
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.