Sync with the v2.x branch #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertdeblock
approved these changes
Mar 27, 2023
|
Can someone re-run the build here? https://github.com/emberjs/ember-test-helpers/actions/runs/4516904757/jobs/7955705788?pr=1361 The failure is sus, based on the changes in this PR |
|
I don't think I can re-run the test, been too long maybe? @NullVoxPopuli can you make sure this is branch is updated with current master and re-push? That should jiggle things to get them running. |
NullVoxPopuli
force-pushed
the
sync-with-v2-x
branch
from
c74f261
to
735739e
Compare
|
looks like an extra commit snuck in, idk how that happened This is the PR it somehow pulled in: #1382 |
NullVoxPopuli
force-pushed
the
sync-with-v2-x
branch
from
735739e
to
64faf85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some confusing comparisons:
I reviewed the code with the following commits, starting with the first one I did not see in my skim of the t
git logonmaster:the only changes missing that I could find that was missing (from looking at the diff of each commit and checking if the code on
mastermatched) was the changelog / package.json changes.