Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extraneous event-dispatcher wiring and a amd/require #1384

Merged
merged 1 commit into from
May 31, 2023
Merged

Remove extraneous event-dispatcher wiring and a amd/require #1384

merged 1 commit into from
May 31, 2023

Conversation

NullVoxPopuli
Copy link
Sponsor Collaborator

@NullVoxPopuli NullVoxPopuli commented May 2, 2023 •
edited

This isn't needed, it seems?

we don't support folks doing setResolver and all apps use setApplication, yeah?

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review May 2, 2023 04:00
simonihmig
simonihmig approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@simonihmig simonihmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indeed looks like some very old and long-forgotten left overs! 😅

@MelSumner MelSumner merged commit cd05f1d into emberjs:master May 31, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonihmig simonihmig simonihmig approved these changes

Assignees
No one assigned
Labels
breaking v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NullVoxPopuli @simonihmig @MelSumner