Fix isComponent types
#1404
Merged
Fix isComponent types
#1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitKrystan
force-pushed
the
fix-is-component
branch
from
5c797c6
to
7d97c7f
Compare
|
Thanks for fixing this -- this issue really puzzled me in #1382 |
NullVoxPopuli
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAICT this change from #1382 is incorrect but coincidentally works because
owneris truthy.It appears that
getInternalComponentManager's signature is(definition: object, isOptional?: true | undefined) => InternalComponentManager | nulland has been for a while:https://github.com/glimmerjs/glimmer-vm/blob/14413355ef6b48c1ab416a91fb7ff950cf8511d8/packages/%40glimmer/manager/lib/internal/index.ts#L177-L211
This issue was exposed by #1389