fix embroider tests #1406
Merged
fix embroider tests #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitKrystan
reviewed
Jun 6, 2023
Co-authored-by: Krystan HuffMenne <kmenne+github@gmail.com>
gitKrystan
approved these changes
Jun 6, 2023
|
This is not really the suggested way to do this. We ship |
NullVoxPopuli
force-pushed
the
fix-embroider-safe
branch
from
a780112
to
aea44f0
Compare
|
thanks, @ef4 I've changed the fix to do the default thing that test-setup recommends |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
@embroider/*packages are no longer released in lockstep, so each version must individually be fetched