Adding extra test for noop test waiter

emberjs · May 14, 2019 · a013a5f · a013a5f
1 parent a104081
commit a013a5f
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 15 deletions.
diff --git a/package.json b/package.json
@@ -25,17 +25,16 @@
     "postpublish": "ember ts:clean"
   },
   "dependencies": {
+    "@types/qunit": "^2.9.0",
     "ember-cli-babel": "^7.1.2"
   },
   "devDependencies": {
     "@ember/optional-features": "^0.6.3",
     "@glimmer/env": "^0.1.7",
     "@types/ember": "^3.0.29",
-    "@types/ember-qunit": "^3.4.5",
     "@types/ember-test-helpers": "^1.0.4",
     "@types/ember-testing-helpers": "^0.0.3",
     "@types/ember__test-helpers": "^0.7.7",
-    "@types/qunit": "^2.5.4",
     "@types/rsvp": "^4.0.2",
     "@typescript-eslint/eslint-plugin": "^1.4.2",
     "@typescript-eslint/parser": "^1.4.2",

diff --git a/tests/unit/waiter-manager-noop-test.ts b/tests/unit/waiter-manager-noop-test.ts
@@ -33,5 +33,16 @@ if (!DEBUG) {
       waiter.endAsync(token);
       assert.ok(waiter.waitUntil(), 'waitUntil returns true');
     });
+
+    test('a NoopTestWaiter always returns true from waitUntil', function(assert) {
+      let waiter = buildWaiter('first');
+      let waiterItem = {};
+
+      assert.ok(waiter.waitUntil(), 'waitUntil returns true');
+      let token = waiter.beginAsync(waiterItem);
+      assert.ok(waiter.waitUntil(), 'waitUntil returns true');
+      waiter.endAsync(token);
+      assert.ok(waiter.waitUntil(), 'waitUntil returns true');
+    });
   });
 }
diff --git a/yarn.lock b/yarn.lock
@@ -1004,15 +1004,7 @@
   resolved "https://registry.yarnpkg.com/@sindresorhus/is/-/is-0.7.0.tgz#9a06f4f137ee84d7df0460c1fdb1135ffa6c50fd"
   integrity sha512-ONhaKPIufzzrlNbqtWFFd+jlnemX6lJAgq9ZeiZtS7I1PIf/la7CW4m83rTXRnVnsMbW2k56pGYu7AUFJD9Pow==
 
-"@types/ember-qunit@^3.4.5":
-  version "3.4.6"
-  resolved "https://registry.yarnpkg.com/@types/ember-qunit/-/ember-qunit-3.4.6.tgz#b09ae84192c16fbd1da0d1be26fa02b67691250d"
-  integrity sha512-ARB2JDNV3qzrZ94fC+YdV9jT9hYAXP8pXcqAVzVEYVL5/upSxKcYZjiCSScpKzXikN8yieIGNqSGArhQrcdzFA==
-  dependencies:
-    "@types/ember" "*"
-    "@types/ember-test-helpers" "*"
-
-"@types/ember-test-helpers@*", "@types/ember-test-helpers@^1.0.4":
+"@types/ember-test-helpers@^1.0.4":
   version "1.0.5"
   resolved "https://registry.yarnpkg.com/@types/ember-test-helpers/-/ember-test-helpers-1.0.5.tgz#b0a8a3b9386ddf372eef11ba95487be806674ca2"
   integrity sha512-LewaqxBqUDxT40Lb8M7r0pDlF78b5O87mQRK+8GqrreK/s3MSX/BXgxi5hbWF3TPJ57iX3G4S2TNO8z8soXYdA==
@@ -1192,10 +1184,10 @@
   resolved "https://registry.yarnpkg.com/@types/minimatch/-/minimatch-3.0.3.tgz#3dca0e3f33b200fc7d1139c0cd96c1268cadfd9d"
   integrity sha512-tHq6qdbT9U1IRSGf14CL0pUlULksvY9OZ+5eEgl1N7t+OA3tGvNpxJCzuKQlsNgCVwbAs670L1vcVQi8j9HjnA==
 
-"@types/qunit@^2.5.4":
-  version "2.5.4"
-  resolved "https://registry.yarnpkg.com/@types/qunit/-/qunit-2.5.4.tgz#0518940acc6013259a8619a1ec34ce0e4ff8d1c4"
-  integrity sha512-VHi2lEd4/zp8OOouf43JXGJJ5ZxHvdLL1dU0Yakp6Iy73SjpuXl7yjwAwmh1qhTv8krDgHteSwaySr++uXX9YQ==
+"@types/qunit@^2.9.0":
+  version "2.9.0"
+  resolved "https://registry.yarnpkg.com/@types/qunit/-/qunit-2.9.0.tgz#0b3fcbe2b92f067856adac82ba3afbc66d8835ac"
+  integrity sha512-Hx34HZmTJKRay+x3sFdEK62I8Z8YSWYg+rAlNr4M+AbwvNUJYxTTmWEH4a8B9ZN+Fl61awFrw+oRicWLFVugvQ==
 
 "@types/rsvp@*", "@types/rsvp@^4.0.2":
   version "4.0.2"