Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve waitFor() types #459

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Commits on Jul 21, 2023

  1. Improve waitFor() types

    Use type arguments & inference to ensure that `waitFor()` in function form returns the same type that it was passed. This prevents it from getting in the way of passing functions as as typed arguments. For example, `ember-concurrency`'s `task()` function expects an async arrow function as its argument, so `task(async () => null)` works, but without this change, `task(waitFor(() => null))` does not because `waitFor(() => null)` is just `Function`.
    bendemboski committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    2161381 View commit details
    Browse the repository at this point in the history