Add support for ember-concurrency@v3 #465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
NullVoxPopuli
force-pushed
the
test-with-ember-concurrency-v3
branch
4 times, most recently
from
6cd5a1d
to
e2c9b21
Compare
NullVoxPopuli
force-pushed
the
test-with-ember-concurrency-v3
branch
from
e2c9b21
to
09b569a
Compare
|
Closing this as it'll be on ember-concurrency to properly integrate with waiters, or provide their own |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context on "The Plan": #458
ember-concurrency@v3 isn't formally supported in
@ember/test-waiters@v3. This PR formally adds it, and ensures that@taskForworksUPDATE: the above statement is false, this is quite non-trivial