Avoid mutating the shared queryParams array on the prototype.

emberjs · Sep 30, 2016 · 09140df · 09140df
1 parent 172d158
commit 09140df
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 14 deletions.
diff --git a/packages/ember-routing/lib/utils.js b/packages/ember-routing/lib/utils.js
@@ -130,11 +130,7 @@ export function calculateCacheKey(prefix, _parts, values) {
   'Array of fully defined objects' style.
 */
 export function normalizeControllerQueryParams(queryParams) {
-  if (queryParams._qpMap) {
-    return queryParams._qpMap;
-  }
-
-  let qpMap = queryParams._qpMap = {};
+  let qpMap = {};
 
   for (let i = 0; i < queryParams.length; ++i) {
     accumulateQueryParamDescriptors(queryParams[i], qpMap);

diff --git a/packages/ember-routing/tests/utils_test.js b/packages/ember-routing/tests/utils_test.js
@@ -5,15 +5,6 @@ import {
 
 QUnit.module('Routing query parameter utils - normalizeControllerQueryParams');
 
-QUnit.test('returns the cached value if that has been previously set', function(assert) {
-  let cached = {};
-  let params = ['foo'];
-  params._qpMap = cached;
-
-  let normalized = normalizeControllerQueryParams(params);
-  equal(cached, normalized, 'cached value returned if previously set');
-});
-
 QUnit.test('converts array style into verbose object style', function(assert) {
   let paramName = 'foo';
   let params = [paramName];