Skip to content

Commit

Permalink
another pass to improve es6 module usage
Browse files Browse the repository at this point in the history
  • Loading branch information
stefanpenner committed Jun 14, 2014
1 parent d6c1246 commit 24348bd
Show file tree
Hide file tree
Showing 81 changed files with 675 additions and 654 deletions.
4 changes: 2 additions & 2 deletions packages/ember-application/lib/ext/controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ import { set } from "ember-metal/property_set";
import EmberError from "ember-metal/error";
import { inspect } from "ember-metal/utils";
import { computed } from "ember-metal/computed";
import { ControllerMixin } from "ember-runtime/controllers/controller";
import ControllerMixin from "ember-runtime/mixins/controller";
import { meta } from "ember-metal/utils";
import { controllerFor } from "ember-routing/system/controller_for";
import controllerFor from "ember-routing/system/controller_for";

function verifyNeedsDependencies(controller, container, needs) {
var dependency, i, l, missing = [];
Expand Down
29 changes: 6 additions & 23 deletions packages/ember-application/lib/system/application.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ import { runLoadHooks } from "ember-runtime/system/lazy_load";
import DAG from "ember-application/system/dag";
import Namespace from "ember-runtime/system/namespace";
import DeferredMixin from "ember-runtime/mixins/deferred";
import { DefaultResolver } from "ember-application/system/resolver";
import DefaultResolver from "ember-application/system/resolver";
import { create } from "ember-metal/platform";
import run from "ember-metal/run_loop";
import { canInvoke } from "ember-metal/utils";
import Container from 'container/container';
import { Controller } from "ember-runtime/controllers/controller";
import Controller from "ember-runtime/controllers/controller";
import EnumerableUtils from "ember-metal/enumerable_utils";
import ObjectController from "ember-runtime/controllers/object_controller";
import ArrayController from "ember-runtime/controllers/array_controller";
Expand All @@ -30,31 +30,14 @@ import AutoLocation from "ember-routing/location/auto_location";
import NoneLocation from "ember-routing/location/none_location";
import BucketCache from "ember-routing/system/cache";

import {
K
} from 'ember-metal/core';
import EmberHandlebars from "ember-handlebars-compiler";
import DeprecatedContainer from "ember-application/system/deprecated-container";

var K = Ember.K;
var ContainerDebugAdapter;

function DeprecatedContainer(container) {
this._container = container;
}

DeprecatedContainer.deprecate = function(method) {
return function() {
var container = this._container;

Ember.deprecate('Using the defaultContainer is no longer supported. [defaultContainer#' + method + '] see: http://git.io/EKPpnA', false);
return container[method].apply(container, arguments);
};
};

DeprecatedContainer.prototype = {
_container: null,
lookup: DeprecatedContainer.deprecate('lookup'),
resolve: DeprecatedContainer.deprecate('resolve'),
register: DeprecatedContainer.deprecate('register')
};

/**
An instance of `Ember.Application` is the starting point for every Ember
application. It helps to instantiate, initialize and coordinate the many
Expand Down
21 changes: 21 additions & 0 deletions packages/ember-application/lib/system/deprecated-container.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
function DeprecatedContainer(container) {
this._container = container;
}

DeprecatedContainer.deprecate = function(method) {
return function() {
var container = this._container;

Ember.deprecate('Using the defaultContainer is no longer supported. [defaultContainer#' + method + '] see: http://git.io/EKPpnA', false);
return container[method].apply(container, arguments);
};
};

DeprecatedContainer.prototype = {
_container: null,
lookup: DeprecatedContainer.deprecate('lookup'),
resolve: DeprecatedContainer.deprecate('resolve'),
register: DeprecatedContainer.deprecate('register')
};

export default DeprecatedContainer;
3 changes: 2 additions & 1 deletion packages/ember-application/lib/system/resolver.js
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ export var Resolver = EmberObject.extend({
@namespace Ember
@extends Ember.Object
*/
export var DefaultResolver = EmberObject.extend({

export default EmberObject.extend({
/**
This will be set to the Application instance when it is
created.
Expand Down
14 changes: 7 additions & 7 deletions packages/ember-application/tests/system/application_test.js
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
/*globals EmberDev */

import Ember from "ember-metal/core";
import {get} from "ember-metal/property_get";
import {set} from "ember-metal/property_set";
import {forEach} from "ember-metal/array";
import { get } from "ember-metal/property_get";
import { set } from "ember-metal/property_set";
import { forEach } from "ember-metal/array";
import run from "ember-metal/run_loop";
import Application from "ember-application/system/application";
import {DefaultResolver} from "ember-application/system/resolver";
import DefaultResolver from "ember-application/system/resolver";
import Router from "ember-routing/system/router";
import View from "ember-views/views/view";
import {Controller} from "ember-runtime/controllers/controller";
import Controller from "ember-runtime/controllers/controller";
import NoneLocation from "ember-routing/location/none_location";
import EmberHandlebars from "ember-handlebars";
import EmberObject from "ember-runtime/system/object";
import {outletHelper} from "ember-routing-handlebars/helpers/outlet";

import { outletHelper } from "ember-routing-handlebars/helpers/outlet";
import jQuery from "ember-views/system/jquery";

var trim = jQuery.trim;

var view, app, application, originalLookup, originalDebug;
Expand Down
2 changes: 1 addition & 1 deletion packages/ember-application/tests/system/controller_test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*jshint newcap:false */

import { Controller } from "ember-runtime/controllers/controller";
import Controller from "ember-runtime/controllers/controller";
import "ember-application/ext/controller";

import Container from "ember-runtime/system/container";
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import jQuery from "ember-views/system/jquery";
import run from "ember-metal/run_loop";
import Application from "ember-application/system/application";
import { DefaultResolver } from "ember-application/system/resolver";
import DefaultResolver from "ember-application/system/resolver";

var application;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Ember from "ember-metal/core"; // Ember.TEMPLATES
import run from "ember-metal/run_loop";
import Logger from "ember-metal/logger";
import { Controller } from "ember-runtime/controllers/controller";
import Controller from "ember-runtime/controllers/controller";
import EmberObject from "ember-runtime/system/object";
import EmberHandlebars from "ember-handlebars";
import Namespace from "ember-runtime/system/namespace";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import Ember from "ember-metal/core"; // lookup, etc
import run from "ember-metal/run_loop";
import Application from "ember-application/system/application";
import EmberObject from "ember-runtime/system/object";
import { DefaultResolver } from "ember-application/system/resolver";
import DefaultResolver from "ember-application/system/resolver";
import { guidFor } from "ember-metal/utils";

var originalLookup, App, originalModelInjections;
Expand Down
2 changes: 1 addition & 1 deletion packages/ember-application/tests/system/logging_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import run from "ember-metal/run_loop";
import Application from "ember-application/system/application";
import View from "ember-views/views/view";
import { Controller } from "ember-runtime/controllers/controller";
import Controller from "ember-runtime/controllers/controller";
import Route from "ember-routing/system/route";
import RSVP from "ember-runtime/ext/rsvp";
import keys from "ember-runtime/keys";
Expand Down
2 changes: 1 addition & 1 deletion packages/ember-application/tests/system/reset_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import Application from "ember-application/system/application";
import EmberObject from "ember-runtime/system/object";
import Router from "ember-routing/system/router";
import View from "ember-views/views/view";
import {Controller} from "ember-runtime/controllers/controller";
import Controller from "ember-runtime/controllers/controller";
import EventDispatcher from "ember-views/system/event_dispatcher";
import jQuery from "ember-views/system/jquery";
import Container from 'container/container';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import Ember from "ember-metal/core";
import { A as emberA } from "ember-runtime/system/native_array";
import { typeOf } from "ember-metal/utils";
import {
dasherize,
Expand Down Expand Up @@ -46,7 +47,7 @@ import EmberObject from "ember-runtime/system/object";
@extends EmberObject
@since 1.5.0
*/
var ContainerDebugAdapter = EmberObject.extend({
export default EmberObject.extend({
/**
The container of the application being debugged.
This property will be injected
Expand Down Expand Up @@ -88,7 +89,7 @@ var ContainerDebugAdapter = EmberObject.extend({
@return {Array} An array of strings.
*/
catalogEntriesByType: function(type) {
var namespaces = Ember.A(Namespace.NAMESPACES), types = Ember.A(), self = this;
var namespaces = emberA(Namespace.NAMESPACES), types = emberA(), self = this;
var typeSuffixRegex = new RegExp(classify(type) + "$");

namespaces.forEach(function(namespace) {
Expand All @@ -107,5 +108,3 @@ var ContainerDebugAdapter = EmberObject.extend({
return types;
}
});

export default ContainerDebugAdapter;
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Ember from "ember-metal/core";
import run from "ember-metal/run_loop";
import EmberObject from "ember-runtime/system/object";
import { Controller as EmberController } from "ember-runtime/controllers/controller";
import { default as EmberController } from "ember-runtime/controllers/controller";
import "ember-extension-support"; // Must be required to export Ember.ContainerDebugAdapter
import Application from "ember-application/system/application";

Expand Down
4 changes: 2 additions & 2 deletions packages/ember-extension-support/tests/data_adapter_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ import {
removeObserver
} from "ember-metal/observer";
import EmberObject from "ember-runtime/system/object";
import { Controller as EmberController } from "ember-runtime/controllers/controller";
import { default as EmberController } from "ember-runtime/controllers/controller";
import EmberDataAdapter from "ember-extension-support/data_adapter";
import EmberApplication from "ember-application/system/application";
import { DefaultResolver } from "ember-application/system/resolver";
import DefaultResolver from "ember-application/system/resolver";

var adapter, App, Model = EmberObject.extend();

Expand Down
23 changes: 15 additions & 8 deletions packages/ember-handlebars/lib/controls/checkbox.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,24 +31,33 @@ import View from "ember-views/views/view";
@namespace Ember
@extends Ember.View
*/
var Checkbox = View.extend({
export default View.extend({
instrumentDisplay: '{{input type="checkbox"}}',

classNames: ['ember-checkbox'],

tagName: 'input',

attributeBindings: ['type', 'checked', 'indeterminate', 'disabled', 'tabindex', 'name',
'autofocus', 'required', 'form'],

type: "checkbox",
attributeBindings: [
'type',
'checked',
'indeterminate',
'disabled',
'tabindex',
'name',
'autofocus',
'required',
'form'
],

type: 'checkbox',
checked: false,
disabled: false,
indeterminate: false,

init: function() {
this._super();
this.on("change", this, this._updateElementValue);
this.on('change', this, this._updateElementValue);
},

didInsertElement: function() {
Expand All @@ -60,5 +69,3 @@ var Checkbox = View.extend({
set(this, 'checked', this.$().prop('checked'));
}
});

export default Checkbox;
15 changes: 9 additions & 6 deletions packages/ember-handlebars/lib/controls/select.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,14 @@
*/

import EmberHandlebars from "ember-handlebars-compiler";
import EnumerableUtils from "ember-metal/enumerable_utils";

import {
forEach,
indexOf,
indexesOf,
replace
} from "ember-metal/enumerable_utils";

import { get } from "ember-metal/property_get";
import { set } from "ember-metal/property_set";
import View from "ember-views/views/view";
Expand All @@ -16,11 +23,7 @@ import { A as emberA } from "ember-runtime/system/native_array";
import { observer } from "ember-metal/mixin";
import { defineProperty } from "ember-metal/properties";

var indexOf = EnumerableUtils.indexOf,
indexesOf = EnumerableUtils.indexesOf,
forEach = EnumerableUtils.forEach,
replace = EnumerableUtils.replace,
precompileTemplate = EmberHandlebars.compile;
var precompileTemplate = EmberHandlebars.compile;

var SelectOption = View.extend({
instrumentDisplay: 'Ember.SelectOption',
Expand Down
2 changes: 1 addition & 1 deletion packages/ember-handlebars/lib/helpers/each.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { get } from "ember-metal/property_get";
import { set } from "ember-metal/property_set";
import CollectionView from "ember-views/views/collection_view";
import { Binding } from "ember-metal/binding";
import { ControllerMixin } from "ember-runtime/controllers/controller";
import ControllerMixin from "ember-runtime/mixins/controller";
import ArrayController from "ember-runtime/controllers/array_controller";
import EmberArray from "ember-runtime/mixins/array";
import copy from "ember-runtime/copy";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import {
} from "ember-views/views/states";
var viewStates = states;

import { _MetamorphView } from "ember-handlebars/views/metamorph_view";
import _MetamorphView from "ember-handlebars/views/metamorph_view";
import { handlebarsGet } from "ember-handlebars/ext";

function SimpleHandlebarsView(path, pathRoot, isEscaped, templateData) {
Expand Down
1 change: 1 addition & 0 deletions packages/ember-handlebars/lib/views/metamorph_view.js
Original file line number Diff line number Diff line change
Expand Up @@ -136,3 +136,4 @@ export var _MetamorphView = View.extend(_Metamorph);
@private
*/
export var _SimpleMetamorphView = CoreView.extend(_Metamorph);
export default View.extend(_Metamorph);
5 changes: 2 additions & 3 deletions packages/ember-handlebars/tests/controls/select_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,14 @@ import EmberObject from "ember-runtime/system/object";
import run from "ember-metal/run_loop";
import EmberView from "ember-views/views/view";
import jQuery from "ember-views/system/jquery";
import EnumerableUtils from "ember-metal/enumerable_utils";
import { map } from "ember-metal/enumerable_utils";
import EventDispatcher from "ember-views/system/event_dispatcher";
import { computed } from "ember-metal/computed";
import Namespace from "ember-runtime/system/namespace";
import ArrayController from "ember-runtime/controllers/array_controller";
import ArrayProxy from "ember-runtime/system/array_proxy";

var map = EnumerableUtils.map,
trim = jQuery.trim;
var trim = jQuery.trim;

var dispatcher, select, view;

Expand Down
3 changes: 1 addition & 2 deletions packages/ember-handlebars/tests/handlebars_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import Ember from "ember-metal/core"; // Ember.lookup
import jQuery from "ember-views/system/jquery";
// import {expectAssertion} from "ember-metal/tests/debug_helpers";
import EnumerableUtils from "ember-metal/enumerable_utils";
import { forEach } from "ember-metal/enumerable_utils";
import run from "ember-metal/run_loop";
import Namespace from "ember-runtime/system/namespace";
import EmberView from "ember-views/views/view";
Expand Down Expand Up @@ -32,7 +32,6 @@ Ember.ContainerView = ContainerView;
Ember.Logger = Logger;

var trim = jQuery.trim;
var forEach = EnumerableUtils.forEach;

import { get } from "ember-metal/property_get";
import { set } from "ember-metal/property_set";
Expand Down
2 changes: 1 addition & 1 deletion packages/ember-handlebars/tests/helpers/each_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import ArrayController from "ember-runtime/controllers/array_controller";
import EmberHandlebars from "ember-handlebars-compiler";
// import {expectAssertion} from "ember-metal/tests/debug_helpers";
import { A } from "ember-runtime/system/native_array";
import { Controller as EmberController } from "ember-runtime/controllers/controller";
import { default as EmberController } from "ember-runtime/controllers/controller";
import ObjectController from "ember-runtime/controllers/object_controller";
import Container from "ember-runtime/system/container";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { set } from "ember-metal/property_set";
import { observer } from "ember-metal/mixin";
import EmberHandlebars from "ember-handlebars-compiler";

import { _MetamorphView } from "ember-handlebars/views/metamorph_view";
import _MetamorphView from "ember-handlebars/views/metamorph_view";

var view, childView, metamorphView;

Expand Down
6 changes: 4 additions & 2 deletions packages/ember-metal/lib/core.js
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,10 @@ Ember.LOG_VERSION = (Ember.ENV.LOG_VERSION === false) ? false : true;
@private
@return {Object}
*/
Ember.K = function() { return this; };

var K = function() { return this; };
export var K = K;
Ember.K = K;
//TODO: ES6 GLOBL TODO

// Stub out the methods defined by the ember-debug package in case it's not loaded

Expand Down

0 comments on commit 24348bd

Please sign in to comment.