App.container was not meant to be a public API

It appears that people are starting to use
App.container.lookup as the public API for
globally getting other controllers outside of the
router or other controllers.

This was not intended to be a public API.

Instead, you should trigger events on a route
(or a parent route), which have access to
`this.controllerFor`.

Example:

    App.ApplicationRoute.extend({
      events: {
        search: function(term) {
          this.controllerFor('search')
            .set('term', term);
        }
      }
    });

    App.SearchField = Ember.TextField.extend({
      insertNewline: function() {
        var term = this.get('value'),
            controller = this.get('controller');

        controller.send('search', term);
        this.set('value', '');
      }
    });

Events sent to the controller will bubble up to
the current route, and then up the route hierarchy

packages/ember-application/lib/system/application.js

@@ -264,7 +264,7 @@ var Application = Ember.Application = Ember.Namespace.extend(
 
   init: function() {
     if (!this.$) { this.$ = Ember.$; }
-    this.container = this.buildContainer();
+    this.__container__ = this.buildContainer();
     this.Router = this.Router || this.defaultRouter();
 
     this._super();
@@ -285,7 +285,7 @@ var Application = Ember.Application = Ember.Namespace.extend(
     @return {Ember.Container} the configured container
   */
   buildContainer: function() {
-    var container = this.container = Application.buildContainer(this);
+    var container = this.__container__ = Application.buildContainer(this);
 
     return container;
   },
@@ -402,6 +402,11 @@ var Application = Ember.Application = Ember.Namespace.extend(
     }
   },
 
+  register: function() {
+    var container = this.__container__;
+    return container.register.apply(container, arguments);
+  },
+
   /**
     @private
 
@@ -419,7 +424,7 @@ var Application = Ember.Application = Ember.Namespace.extend(
     this.isInitialized = true;
 
     // At this point, the App.Router must already be assigned
-    this.container.register('router', 'main', this.Router);
+    this.__container__.register('router', 'main', this.Router);
 
     // Run any injections and run the application load hook. These hooks may
     // choose to defer readiness. For example, an authentication hook might want
@@ -440,9 +445,9 @@ var Application = Ember.Application = Ember.Namespace.extend(
     @method runInitializers
   */
   runInitializers: function() {
-    var router = this.container.lookup('router:main'),
+    var router = this.__container__.lookup('router:main'),
         initializers = get(this.constructor, 'initializers'),
-        container = this.container,
+        container = this.__container__,
         graph = new Ember.DAG(),
         namespace = this,
         properties, i, initializer;
@@ -517,7 +522,7 @@ var Application = Ember.Application = Ember.Namespace.extend(
     @property router {Ember.Router}
   */
   startRouting: function() {
-    var router = this.container.lookup('router:main');
+    var router = this.__container__.lookup('router:main');
     if (!router) { return; }
 
     router.startRouting();
@@ -537,7 +542,7 @@ var Application = Ember.Application = Ember.Namespace.extend(
     var eventDispatcher = get(this, 'eventDispatcher');
     if (eventDispatcher) { eventDispatcher.destroy(); }
 
-    this.container.destroy();
+    this.__container__.destroy();
   },
 
   initializer: function(options) {

packages/ember-application/tests/system/application_test.js

@@ -111,7 +111,7 @@ test('initialized application go to initial route', function() {
       match("/").to("index");
     });
 
-    app.container.register('template', 'application',
+    app.register('template', 'application',
       Ember.Handlebars.compile("{{outlet}}")
     );
 
@@ -144,7 +144,9 @@ test("initialize application via initialize call", function() {
     });
   });
 
-  var router = app.container.lookup('router:main');
+  // This is not a public way to access the container; we just
+  // need to make some assertions about the created router
+  var router = app.__container__.lookup('router:main');
   equal(router instanceof Ember.Router, true, "Router was set from initialize call");
   equal(router.location instanceof Ember.NoneLocation, true, "Location was set from location implementation name");
 });
@@ -165,12 +167,12 @@ test("initialize application with stateManager via initialize call from Router c
       match("/").to("index");
     });
 
-    app.container.register('template', 'application', function() {
+    app.register('template', 'application', function() {
       return "<h1>Hello!</h1>";
     });
   });
 
-  var router = app.container.lookup('router:main');
+  var router = app.__container__.lookup('router:main');
   equal(router instanceof Ember.Router, true, "Router was set from initialize call");
   equal(Ember.$("#qunit-fixture h1").text(), "Hello!");
 });