Skip to content

Commit

Permalink
Fix node: EventDispatcher references document global
Browse files Browse the repository at this point in the history
  • Loading branch information
chancancode committed Feb 26, 2021
1 parent 97bd0a2 commit 9973c42
Showing 1 changed file with 17 additions and 11 deletions.
28 changes: 17 additions & 11 deletions packages/@ember/-internals/views/lib/system/event_dispatcher.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,18 +121,8 @@ export default EmberObject.extend({

init() {
this._super();

assert(
'EventDispatcher should never be instantiated in fastboot mode. Please report this as an Ember bug.',
(() => {
let owner = getOwner(this);
let environment = owner.lookup('-environment:main');

return environment.isInteractive;
})()
);

this._eventHandlers = Object.create(null);
this._didSetup = false;
},

/**
Expand All @@ -148,6 +138,16 @@ export default EmberObject.extend({
@param addedEvents {Object}
*/
setup(addedEvents, _rootElement) {
assert(
'EventDispatcher should never be setup in fastboot mode. Please report this as an Ember bug.',
(() => {
let owner = getOwner(this);
let environment = owner.lookup('-environment:main');

return environment.isInteractive;
})()
);

let events = (this._finalEvents = assign({}, get(this, 'events'), addedEvents));

if (_rootElement !== undefined && _rootElement !== null) {
Expand Down Expand Up @@ -230,6 +230,8 @@ export default EmberObject.extend({
this.setupHandler(rootElement, event, events[event]);
}
}

this._didSetup = true;
},

/**
Expand Down Expand Up @@ -432,6 +434,10 @@ export default EmberObject.extend({
},

destroy() {
if (this._didSetup === false) {
return;
}

let rootElementSelector = get(this, 'rootElement');
let rootElement;
if (rootElementSelector.nodeType) {
Expand Down

0 comments on commit 9973c42

Please sign in to comment.