Merge pull request #20501 from boris-petrov/fix-native-array-mutation…

…-method-types [BUGFIX stable] Fix the types for the mutation-methods of `NativeArray`
emberjs · Jul 11, 2023 · 9e51c36 · 9e51c36
2 parents 3d43480 + bdefd5f
commit 9e51c36
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/packages/@ember/array/index.ts b/packages/@ember/array/index.ts
@@ -1899,7 +1899,7 @@ const MutableArray = Mixin.create(EmberArray, MutableEnumerable, {
 @module ember
 */
 
-type AnyArray<T> = EmberArray<T> | Array<T>;
+type AnyArray<T> = EmberArray<T> | Array<T> | ReadonlyArray<T>;
 
 /**
  * The final definition of NativeArray removes all native methods. This is the list of removed methods

diff --git a/packages/@ember/array/type-tests/index.test.ts b/packages/@ember/array/type-tests/index.test.ts
@@ -205,6 +205,10 @@ expectTypeOf(arr.without(foo)).toEqualTypeOf<NativeArray<Foo>>();
 // @ts-expect-error invalid type
 arr.without(1);
 
+expectTypeOf(arr.pushObjects(arr)).toEqualTypeOf<NativeArray<Foo>>();
+expectTypeOf(arr.pushObjects([foo] as Foo[])).toEqualTypeOf<NativeArray<Foo>>();
+expectTypeOf(arr.pushObjects([foo] as readonly Foo[])).toEqualTypeOf<NativeArray<Foo>>();
+
 expectTypeOf(isArray(arr)).toEqualTypeOf<boolean>();
 
 expectTypeOf(makeArray(arr)).toEqualTypeOf<NativeArray<Foo>>();