ensure we don’t needlessly scan the concatenated properties array

emberjs · Oct 15, 2014 · ad5df21 · ad5df21
1 parent fbf91df
commit ad5df21
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 2 deletions.
diff --git a/packages/ember-metal/lib/mixin.js b/packages/ember-metal/lib/mixin.js
@@ -194,7 +194,11 @@ function applyConcatenatedProperties(obj, key, value, values) {
 
   if (baseValue) {
     if ('function' === typeof baseValue.concat) {
-      return baseValue.concat(value);
+      if (value === null || value === undefined) {
+        return baseValue;
+      } else {
+        return baseValue.concat(value);
+      }
     } else {
       return makeArray(baseValue).concat(value);
     }

diff --git a/packages/ember-metal/tests/mixin/concatenatedProperties_test.js b/packages/ember-metal/tests/mixin/concatenatedProperties_test.js
@@ -15,6 +15,22 @@ test('defining concatenated properties should concat future version', function()
   deepEqual(Ember.get(obj, 'foo'), ['a', 'b', 'c', 'd', 'e', 'f']);
 });
 
+test('defining concatenated properties should concat future version', function() {
+
+  var MixinA = Ember.Mixin.create({
+    concatenatedProperties: null,
+  });
+
+  var MixinB = Ember.Mixin.create({
+    concatenatedProperties: null,
+  });
+
+  var obj = Ember.mixin({}, MixinA, MixinB);
+
+  deepEqual(obj.concatenatedProperties, []);
+});
+
+
 test('concatenatedProperties should be concatenated', function() {
 
   var MixinA = Ember.Mixin.create({

diff --git a/packages/ember-runtime/lib/system/core_object.js b/packages/ember-runtime/lib/system/core_object.js
@@ -132,7 +132,9 @@ function makeCtor() {
                        "time, when Ember.ActionHandler is used (i.e. views, " +
                        "controllers & routes).", !((keyName === 'actions') && ActionHandler.detect(this)));
 
-          if (concatenatedProperties && indexOf(concatenatedProperties, keyName) >= 0) {
+          if (concatenatedProperties && 
+              concatenatedProperties.length > 0 &&
+              indexOf(concatenatedProperties, keyName) >= 0) {
             var baseValue = this[keyName];
 
             if (baseValue) {