[BUGFIX beta] Update verifyNeedsDependencies to throw instead of as…

…sert. A missing `needs` dependency should raise an error in production builds, not just in dev builds.
emberjs · Jan 2, 2014 · c22755d · c22755d
1 parent 92b4648
commit c22755d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/packages/ember-application/lib/ext/controller.js b/packages/ember-application/lib/ext/controller.js
@@ -22,7 +22,9 @@ function verifyNeedsDependencies(controller, container, needs) {
       missing.push(dependency);
     }
   }
-  Ember.assert(Ember.inspect(controller) + " needs [ " + missing.join(', ') + " ] but " + (missing.length > 1 ? 'they' : 'it') + " could not be found", !missing.length);
+  if (missing.length) {
+    throw new Ember.Error(Ember.inspect(controller) + " needs [ " + missing.join(', ') + " ] but " + (missing.length > 1 ? 'they' : 'it') + " could not be found");
+  }
 }
 
 var defaultControllersComputedProperty = Ember.computed(function() {

diff --git a/packages/ember-application/tests/system/controller_test.js b/packages/ember-application/tests/system/controller_test.js
@@ -32,15 +32,15 @@ test("If a controller specifies an unavailable dependency, it raises", function(
     needs: ['comments']
   }));
 
-  expectAssertion(function() {
+  throws(function() {
     container.lookup('controller:post');
   }, /controller:comments/);
 
   container.register('controller:blog', Ember.Controller.extend({
     needs: ['posts', 'comments']
   }));
 
-  expectAssertion(function() {
+  throws(function() {
     container.lookup('controller:blog');
   }, /controller:posts, controller:comments/);
 });