Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember no longer defers to ember-cli's resolver #10907

Closed
bcardarella opened this issue Apr 19, 2015 · 1 comment
Closed

Ember no longer defers to ember-cli's resolver #10907

bcardarella opened this issue Apr 19, 2015 · 1 comment

Comments

@bcardarella
Copy link
Contributor

Since e5148e6 the decoupling of the Registry from the Container broke the API for deferring to ember-cli's Resolver.

Specifically, resolveOther is no longer being called for ember-resolver. This broke ember-validations as it is relying upon resolving outside of the application's namespace: https://github.com/dockyard/ember-validations/blob/master/addon/mixin.js#L55-L56 which is a feature supported by ember-resolve since 0.1.8 (Oct '14)

I believe this should be treated as a bug and patched rather than backporting ember-resolver's support into the Registry.

/cc @dgeb @stefanpenner @rwjblue

@bcardarella
Copy link
Contributor Author

False alarm, I was not building my container properly in the test suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant