-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another question to volatile() #1202
Comments
Is this related to #957? |
yes, but it showed to be a problem not with closure compiler but with other tools too. |
Gotcha. Should have read a bit closer. This is a question better suited for @wycats. |
@jankopriva Can you give me examples of actual libraries that fail? I'm not seeing failures on current JSLint. We've also tested in IE8 without any visible issues related to |
yuicompressor https://github.com/yui/yuicompressor/ I realize javascript lint is quite old and probably not developed any more, but yuicompressor is quite popular. |
@jankopriva Hmm, this does seem to be reserved in YUI Compressor. In my opinion, this is a bug in YUI. They have removed other previously reserved words for ES5 but have only done a partial job. I can't see any point in reserving ES3 words when they are no longer reserved in ES5 and were never used in ES3. |
Ok, thanks for the answer. I will patch yuicompressor, then. |
It also breaks in Rhino saying org.mozilla.javascript.EvaluatorException: missing name after . operator |
Looks like YUICompressor is deprecated http://www.yuiblog.com/blog/2012/10/16/state-of-yui-compressor/. |
@wagenet If someone can demonstrate problems in any browser (IE6?, IE7? IE8?), I'll reconsider. Just supporting extremely old non-browser environments that are not up-to-date with modern JavaScript is not a good enough reason imho. |
@wycats Sounds good to me. |
Hi I'm trying to run an ember precompiler for the play framework and I'm getting affected but the usage of the volatile keyword. The error given by rhino is where we have the definition of Changing the language version in Rhino has no effect |
I've run into this with Closure Compiler as well. I had to add the following to my plovr config: |
Note: people trying the closure compiler web ui can use |
Hi all,
I have run into issue with volatile being a reserved word in js. That means that older tools like yuicompressor and javascript lint will not work with new ember apps. I noticed pull request #957 Don't use reserved word 'volatile' for non-cached properties
with explanation that this is EC3 vs EC5 issues.
However, not only closure compiler but also other tools fail and I would like to know what's the ember community view on this:
Definitely stick with volatile keyword in ember or patch the old tools to remove volatile check restriction?
Also, I am not sure, whether using volatile does not break IE8 functionality.
Thanks.
The text was updated successfully, but these errors were encountered: