Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Glimmer Component] Quoted/Unquoted Attributes #12133

Closed
chadhietala opened this issue Aug 17, 2015 · 3 comments
Closed

[Glimmer Component] Quoted/Unquoted Attributes #12133

chadhietala opened this issue Aug 17, 2015 · 3 comments

Comments

@chadhietala
Copy link
Contributor

It appears that with glimmer components there is an issue with quoted vs unquoted attributes on the top-level elements.

http://emberjs.jsbin.com/qaloyad/

@rwjblue
Copy link
Member

rwjblue commented Aug 18, 2015

/cc @wycats

@pixelhandler
Copy link
Contributor

@chadhietala I'm not sure what is the proper use of unquoted use of curly braces on an attribute of a component, but it seems to me that the curly braces should be inside quotes. I found it odd to see src={{src}}, I would have expected src=src instead of unquoted curlies; however this does look proper src="{{src}}".

I recall the blog post announcing the glimmer release had an example of an attribute that used curlies inside of quotes.

Supports angle-bracket components (<my-component />), ergonomic attributes (<my-link href="{{url}}.html">go home</my-link>), that hews closely to HTML syntax with a few small enhancements.

@rwjblue
Copy link
Member

rwjblue commented Apr 18, 2016

The thinking on this has changed a bit, and the initial angle bracket component implementation has been removed. When this is reintroduced, there will be an updated RFC with more details on the path forward for this type of thing.

Closing for now, since the feature doesn't exist in the codebase...

@rwjblue rwjblue closed this as completed Apr 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants