Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdapterError persisting despite route error-hook treatment #12472

Closed
samcic opened this issue Oct 10, 2015 · 2 comments · Fixed by #12752
Closed

AdapterError persisting despite route error-hook treatment #12472

samcic opened this issue Oct 10, 2015 · 2 comments · Fixed by #12752

Comments

@samcic
Copy link

samcic commented Oct 10, 2015

Here are two JSbins:

http://emberjs.jsbin.com/qilozufiwa/1/edit?html,js,console,output
http://emberjs.jsbin.com/panodeneja/edit?html,js,console,output

Both are identical, except that the first uses Ember Data 2.0 and Ember 2.0, and the second uses Ember Data 2.1 and Ember 2.1.

Both just represent an app which enters a route 'Testroute' and tries to get a 'Testmodel' record as its model. The adapter fails to get this record, rejecting the promise with an AdapterError. Back in the route, we handle the error by transitioning to the 'servererror' route.

Although both versions successfully transition to the 'servererror' route, in the second (Ember(-data) 2.1) we see an error in the console.

This error-reporting/persistence in 2.1 seems to be breaking some of our tests. Is anybody able to comment on whether this is a regression, or if there's something wrong with the error handling on the route in the JSBin, or if dumping to the console is now expected?

@pixelhandler
Copy link
Contributor

@samcic have you asked this question in the http://embercommunity.slack.com #ember-data and/or #needhelp channel?

Also see this jsbin with examples on catching that error using Ember.onerror - http://emberjs.jsbin.com/daruki/5/edit?js,console

@swalkinshaw
Copy link
Contributor

Just wanted to add that we're experiencing the same behaviour and bug.

It also appears this has been reported before: #12166 (3rd point and this comment by @rwjblue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants