Ember.Object is undefined

[rondale-sc]

Seems as if on canary Ember.Object is undefined. I discovered this when loading the following jsbin:

http://jsbin.com/qoyiyegava/edit?html,js,console

[rwjblue]

This is being caused by this line:

Mixin.prototype.toString = classToString;

In combination with sealing inside Mixin's init.

[rondale-sc]

Was able to reduce the jsbin's complexity a bit and still show the issue:

http://jsbin.com/dipipe/2/edit?html,js,console,output

[rwjblue]

After more toying around with this, the issue is with the load order of modules.

Working Demo: http://jsbin.com/kijavi/edit?html,js,console
Failing Demo: http://jsbin.com/yebonov/edit?html,js,console

---

Working:

<script src="http://builds.emberjs.com/canary/ember.debug.js"></script>
<script src="http://builds.emberjs.com/canary/ember-template-compiler.js"></script>

Failing:

<script src="http://builds.emberjs.com/canary/ember-template-compiler.js"></script>
<script src="http://builds.emberjs.com/canary/ember.debug.js"></script>

[rwjblue]

Basically, if ember-template-compiler.js (which only includes ember-metal, and not runtime) is loaded first then ember-runtime modules are loaded and try to add toString property to Mixin after its init.

[rondale-sc]

This wouldn't affect ember-cli applications then?

[rwjblue]

@rondale-sc - Correct.

[rondale-sc]

Interesting. Is this a bug then? Globals still work if specified in the correct order. Should I close?

[rwjblue]

@rondale-sc - I am unsure. It is definitely not wonderful that what used to work now does not work.

[rondale-sc]

True, but I'm not sure how you'd get the seal effect without order dependence.

[krisselden]

Honestly I think we should just drop this for Mixins, it is rare in the ember cli world to assign them to a Namespace.

[krisselden]

@rwjblue do we strip 'use strict' in debug builds?

[krisselden]

so, I understand now what is going on, I didn't catch this because debugSeal is normally a noop, it is the template compiler that makes it not a noop. I intended to do this, but I would have caught this error if the debug functions actually worked via the module import.

[rwjblue]

We strip use strict only on a small number of modules (5 I think?) as a work around to a nasty iOS bug.

[knownasilya]

Is this a related bug? FirebaseExtended/emberfire#340