Check that a controller inherits from Ember.Object before instantiating it to the router. #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before instantiating it to the router.
|
Just to clarify, it's not good practice to have non-objects named as such, but this PR is unlikely to cause any problems. |
wagenet
added a commit
that referenced
this pull request
Sep 10, 2012
Check that a controller inherits from Ember.Object before instantiating it to the router.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that a Controller is at least an Ember.Object. This gives the ability for people to have capitalized controller objects or functions in their main application namespace.
See discussion on emberjs/data#352
cc/ @wagenet