Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--dummy flag doesn't work for route blueprint #14324

Closed
SaladFork opened this issue Sep 21, 2016 · 5 comments
Closed

--dummy flag doesn't work for route blueprint #14324

SaladFork opened this issue Sep 21, 2016 · 5 comments

Comments

@SaladFork
Copy link
Contributor

SaladFork commented Sep 21, 2016

$ ember --version
ember-cli: 2.8.0
node: 6.3.1
os: darwin x64

$ npm ls --depth=0 | grep ember-cli@
├── ember-cli@2.8.0

$ bower ls | grep -m1 ember#
├─┬ ember#2.8.1 (latest is 2.9.0-beta.3)

$ ember addon ember-cli-foo
installing addon
…
Successfully initialized git.
Installed packages for tooling via npm.
Installed browser packages via Bower.

$ ember g controller foo --dummy     # works as expected
installing controller
  create tests/dummy/app/controllers/foo.js

$ ember g route foo --dummy          # generates app route, not dummy
installing route
  create app/routes/foo.js
  create app/templates/foo.hbs
updating router
  add route foo

Was able to reproduce with master of both ember-cli and ember (though I suspect this might not matter since it seems we're not including ember as an addon in package.json yet):

$ npm link ember-cli
$ ember --version

Missing symlinked npm packages:
Package: ember-cli
  * Specified: 2.8.0
  * Symlinked: 2.9.0-beta.2

ember-cli: 2.9.0-beta.2-master-70e480baf7
node: 6.3.1
os: darwin x64

$ bower install --save ember#master
…
    1) ember#master which resolved to 1721af7ffd
…

$ bower ls | grep -m1 ember#
├─┬ ember#1721af7ffd

$ ember g route foo --dummy          # generates app route, not dummy

Missing symlinked npm packages:
Package: ember-cli
  * Specified: 2.8.0
  * Symlinked: 2.9.0-beta.2

installing route
  create app/routes/foo.js
  create app/templates/foo.emblem
updating router
  add route foo

(wasn't sure if to file this here or on ember-cli, but since the route blueprint seems to be living here now it seemed more appropriate)

@locks
Copy link
Contributor

locks commented Sep 21, 2016

@SaladFork ember-cli please. From what was explained to me, the blueprints in this repo aren't actually used by CLI, but ember-legacy-blueprints instead.

@SaladFork
Copy link
Contributor Author

Should I repost to ember-cli or ember-cli-legacy-blueprints? Is it worth keeping this open so we can fix the blueprint here as well if/when the switch is made?

@rwjblue
Copy link
Member

rwjblue commented Sep 22, 2016

We need to fix in both legacy blueprints and here, I'm happy to keep this open as a meta issue though.

@locks locks self-assigned this Apr 16, 2017
@pixelhandler
Copy link
Contributor

@SaladFork @locks @rwjblue is this still an issue, perhaps we should close; what do you think?

@pixelhandler
Copy link
Contributor

Per our triage policy I'll close this out for now, feel free to reopen if the issue persists on the current release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants