Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angle Bracket Invocation allows implicit this with paths #16712

Closed
rwjblue opened this issue Jun 3, 2018 · 4 comments
Closed

Angle Bracket Invocation allows implicit this with paths #16712

rwjblue opened this issue Jun 3, 2018 · 4 comments

Comments

@rwjblue
Copy link
Member

rwjblue commented Jun 3, 2018

Per the angle bracket invocation RFC using a path for invocation should not use “implicit this” fallback.

Specifically, the following should not render a curried component at this.foo.bar:

<foo.bar />
@rwjblue
Copy link
Member Author

rwjblue commented Jun 4, 2018

The RFC's reasoning seemed to be about avoiding costly this.div type lookups in the non-path case (e.g. <div></div>), but it isn't completely clear to me that we also want to require this. for paths.

Specifically, I think that it may make more sense to limit the explicit this. requirement to cases that are not paths already (which satisfies the <div></div> case I mentioned above), and leave completely removing the implicit this to emberjs/rfcs#308.

@chancancode - What do you think?

@rwjblue
Copy link
Member Author

rwjblue commented Jun 4, 2018

Chatted with @chancancode, the RFC's language was intentional. glimmerjs/glimmer-vm#827 should fix this for us once released.

@pixelhandler
Copy link
Contributor

@rwjblue closing for now, that should have been released by now, correct?

glimmerjs/glimmer-vm#827

@rwjblue
Copy link
Member Author

rwjblue commented Sep 29, 2018

Ya, perfect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants