Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canary build of query-params-new (broken) vs old query-params. #4048

Closed
billxinli opened this issue Jan 3, 2014 · 5 comments
Closed

Canary build of query-params-new (broken) vs old query-params. #4048

billxinli opened this issue Jan 3, 2014 · 5 comments

Comments

@billxinli
Copy link

Hi:

Ember 1.4.0-beta.1+canary.9321818e's query-params feature has been working great until the recent canary build 1.4.0-beta.1+canary.2f979e2b

Where it seems that the query-params feature has been replaced with query-params-new, and the following error is happening.

Error while loading route: TypeError: Object [object Object] has no method 'paramsFor'
    at Ember.Route.Ember.Object.extend.deserialize (http://localhost:3000/assets/ember.js?body=1:34733:30)
    at http://localhost:3000/assets/ember.js?body=1:31318:57
    at http://localhost:3000/assets/ember.js?body=1:31782:19
    at invokeResolver (http://localhost:3000/assets/ember.js?body=1:9062:9)
    at new Promise (http://localhost:3000/assets/ember.js?body=1:9049:7)
    at Router.async (http://localhost:3000/assets/ember.js?body=1:31781:16)
    at Object.HandlerInfo.runSharedModelHook (http://localhost:3000/assets/ember.js?body=1:31317:16)
    at Object.UnresolvedHandlerInfoByParam.getModel (http://localhost:3000/assets/ember.js?body=1:31401:19)
    at http://localhost:3000/assets/ember.js?body=1:32893:19
    at invokeCallback (http://localhost:3000/assets/ember.js?body=1:9074:19) 
@rwjblue
Copy link
Member

rwjblue commented Jan 3, 2014

@billxinli - The query-params implementation has been completely re-written. The feature flag query-params-new is referencing the rewritten version.

Please review the PR that added it (#4008) for more details on how it works now.

@rwjblue
Copy link
Member

rwjblue commented Jan 3, 2014

The last canary build with the prior version of query params is:

http://builds.emberjs.com/canary/shas/4d69bca7b031be2e2301b9b7118eddb1dc1ebd7c/ember.js
http://builds.emberjs.com/canary/shas/4d69bca7b031be2e2301b9b7118eddb1dc1ebd7c/ember.prod.js
http://builds.emberjs.com/canary/shas/4d69bca7b031be2e2301b9b7118eddb1dc1ebd7c/ember.min.js

Feel free to use these for now, but you will likely need to update to the new implementation to receive further updates/fixes.

@billxinli
Copy link
Author

Thanks for the pointers @rjackson. Before I go ahead and update to the latest version of query param. I was wondering, is this new version of query-params-new here to stay?

@rwjblue
Copy link
Member

rwjblue commented Jan 3, 2014

@billxinli - Yes, I believe that this is probably pretty close to the final API.

query-params-new will likely not be enabled (it is up to the core-team to decide) by default in 1.4.0 which will ship around 2014/02/14. I am hopeful that it will ship enabled by default with 1.5.0 (which should start beta around 2014/02/14 and be released around 2014/03/28).

FYI - I'm going to go ahead and close this issue since I don't think this is a "bug" per-se (just a breaking change in canary between query-params and query-params-new).

@rwjblue rwjblue closed this as completed Jan 3, 2014
@billxinli
Copy link
Author

Thanks for the updates, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants