Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Router logs non error object rejects poorly #4691

Closed
stefanpenner opened this issue Apr 10, 2014 · 0 comments · Fixed by #4698
Closed

Router logs non error object rejects poorly #4691

stefanpenner opened this issue Apr 10, 2014 · 0 comments · Fixed by #4698

Comments

@stefanpenner
Copy link
Member

Some people reject with non error objects (likely not a good idea), but provide a message property. The error logging in the router only logs the stack.

see: https://github.com/emberjs/ember.js/blob/master/packages_es6/ember-routing/lib/system/router.js#L525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX beta] Better error message for rejected routes. rwjblue/ember.js
1 participant
@stefanpenner