Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expected deprecations in test output should be hidden #4748

Closed
stefanpenner opened this issue Apr 21, 2014 · 6 comments
Closed

expected deprecations in test output should be hidden #4748

stefanpenner opened this issue Apr 21, 2014 · 6 comments
Assignees
Labels

Comments

@stefanpenner
Copy link
Member

We once had this, now we do not. Without this it is not possible to know if we are hitting deprecated code unintentionally.

@rwjblue rwjblue self-assigned this Apr 21, 2014
@stefanpenner
Copy link
Member Author

@mixonic got time to look into this one?

@mixonic
Copy link
Sponsor Member

mixonic commented Aug 1, 2014

Expected deprecations are not shown.

expectDeprecation(function(){
  Ember.deprecate('this is hidden');
});

There is a lot of stuff that is firing deprecations due to tests that have not be changed to a new syntax. Is there something specific? I see gobs of stuff for Ember.Set being deprecated, but that just points to a lazy merge- the patch should not have gone in until there were no deprecations raise from tests (imo).

@stefanpenner
Copy link
Member Author

@mixonic yes, I think deprecation warnings should be test failures for ember itself

@rwjblue
Copy link
Member

rwjblue commented Aug 3, 2014

#5309 and #5307 clear up many of the recent deprecations (Ember.Set and global template lookup specifically).

Still have a few more that need to be tackled.

@wagenet
Copy link
Member

wagenet commented Nov 1, 2014

@stefanpenner @rwjblue @mixonic status?

@rwjblue
Copy link
Member

rwjblue commented Nov 2, 2014

As of #9344, it is no longer possible to pass a Travis run when unhandled deprecations are thrown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants