New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ember templates not properly preserving white space in Ember 1.8.0-beta 5 #9346
Comments
Seems to work properly: http://emberjs.jsbin.com/rwjblue/88/edit Can you provide a failing test or JSBin demonstrating the problem? |
@bravo585 please provide some more information if this is still occurring. A specific browser? |
I'm using the latest version of Chrome (Version 38.0.2125.104) on a Mac. I would like to provide more detail, but I'm not sure how to isolate the problem, because it's only happening in one part of my template. I am not styling the view in any way, or doing anything weird with the CSS (like letter-spacing: 0). |
As we cannot seem to recreate this I'm going to close it. @bravo585 if we are breaking whitespace it would definitely be a bug. I just need more to go on for debugging. |
I updated my project to use Ember 1.8.0 today and I'm, too, seeing the issue of breaking "white space"s within templates. @mixonic It seems that this issue is only present if you work with values which are resolved after the DOM was rendered (see my jsbin example) My system: Windows 8.1, Chrome 38.0.2125.104 m I'd vote for reopening this issue as this really seems like a bug to me! /cc @rwjblue (I updated your previous jsbin example too) |
Demonstrating the difference between initially and late rendered content with whitespace between: http://emberjs.jsbin.com/hijuza/1/edit?html,js,output Definitely a bug. Thanks much for the repro @herom! |
you're welcom @mixonic 😃 - I just updated your jsbin (you had a little typo) to make it work as a whole 😸 |
This is a bug in Chrome's rendering engine :-( The blank text node is still present between the two names, it is simply not rendered. Firefox does not exhibit this bug. |
omg! Yes, I can confirm this - tried it on the following browsers with only seeing this "bug" in latest Chrome. Windows 8.1 64bit:
Mac OSX:
|
Bug at Chrome: https://code.google.com/p/chromium/issues/detail?id=428313 |
Following the bug at Chrome - seems they're moving forward on solving this issue. Thanks a lot @mixonic! 👍 😃 |
I'm going to close this issues as a #wontfix, but a little context: Kris has been working on a refactoring of morph (the library that uses blank text nodes and triggers this bug). The refactor will land with two things to help address this:
This refactor will land in 1.9 or 1.10, but putting into 1.8.1 or another point release is too risky. Ember will address this in an upcoming major release, and hopefully Chrome will have a real fix in an upcoming stable. |
This upstream issue for this has been addressed, and the fix should be included with Chrome 41 (stable on April 3rd). |
thanks a lot @mixonic - I got the notifications from the chromium board too 👍 |
I think there is still a problem related to white spaces. White spaces between ember components aren't preserved. I tested in Chrome, Firefox and Safari, the behaviour is the same in all of them. Ember 1.10 Ember beta Ember canary |
Seems like last summer there was a regression in Chrome that re-introduced this issue https://bugs.chromium.org/p/chromium/issues/detail?id=428313 |
After upgrading from 1.7.0 to Ember 1.8.0 beta 5, this snippet is no longer outputting the proper white space:
If filterUser is "John" and "Doe", it will output "JohnDoe", when it should be "John Doe". If I used the computed property {{filterUser.fullName}} instead, it would properly display the white space "John Doe".
The text was updated successfully, but these errors were encountered: