Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Ember.create is used, and remove strict mode. #9403

Closed
rwjblue opened this issue Oct 27, 2014 · 1 comment · Fixed by #9410
Closed

Ensure Ember.create is used, and remove strict mode. #9403

rwjblue opened this issue Oct 27, 2014 · 1 comment · Fixed by #9410
Milestone
Outstanding 1.8 i...

Comments

@rwjblue
Copy link
Member

rwjblue commented Oct 27, 2014

As a stop-gap solution for https://bugs.webkit.org/show_bug.cgi?id=138038 (reported in #5606) we need to move all Object.create calls to use Ember.create, and also ensure that the module Ember.create resides in is not in strict mode.

Working on these changes now, but I wanted to ensure that this was included in the milestone (so I don't forget).
@rwjblue rwjblue added this to the Outstanding 1.8 issues milestone Oct 27, 2014
@rwjblue rwjblue mentioned this issue Oct 27, 2014
Merged
@rwjblue
Copy link
Member Author

rwjblue commented Oct 27, 2014

#9406 moved Ember.create into a separate module.

This was referenced Oct 27, 2014
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Outstanding 1.8 issues
Development

Successfully merging a pull request may close this issue.

[BUGFIX beta] Remove use strict mode for Object.create usage. rwjblue/ember.js
1 participant
@rwjblue