[DOC UPDATE] target is optional for service.addObserver #12768
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based on my observation of this code: https://github.com/emberjs/ember.js/blob/v2.2.0/packages/ember-metal/lib/events.js#L87 Sorry I don't have time to make a better pull request right now. The documentation could probably use a full update and this PR could be discarded once that is started
|
Hi @devinrhode2, I'm closing this PR as from your description it seems to be partial work. Feel free to re-open it if you're able to push it through completion! |
|
It was frustrating to have to discover this in the source and now you're
just going to throw away the contribution for what.. pr count? just merge
it instead?
…On Tue, Nov 8, 2016 at 1:38 AM, Ricardo Mendes ***@***.***> wrote:
Closed #12768 <#12768>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12768 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAg8qPFPMkYfO3nnc9rt9-x5vdBEVIA1ks5q8CbzgaJpZM4G9qEC>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on my observation of this code: https://github.com/emberjs/ember.js/blob/v2.2.0/packages/ember-metal/lib/events.js#L87
Sorry I don't have time to make a better pull request right now. The documentation could probably use a full update and this PR could be discarded once that is started