Fix models is undefined #12846
Closed
Fix models is undefined #12846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes error when model is undefined
| @@ -716,7 +716,7 @@ let LinkComponent = EmberComponent.extend({ | |||
| }), | |||
|
|
|||
| _modelsAreLoaded: computed('models', function computeLinkToComponentModelsAreLoaded() { | |||
| let models = get(this, 'models'); | |||
| let models = get(this, 'models') | []; | |||
There was a problem hiding this comment.
I don't think you want to use bitwise OR.
|
this needs tests, and we need to see an example that illustrates this issue. I suspect it is an unrelated issue, and making this code defensive will merely hide the real issue. |
added missing |
|
☔ The latest upstream changes (presumably #13381) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Hi @mohlek, I'm closing this as the component is now part of the ember-glimmer package. If you still intend to pursue this, please submit a follow up PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes error when model is undefined
#12845