-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support namespaced references in resolver #1679
Conversation
- Requires separating namespace components with "/" - Assumes it can access all components using normal "." notation
Could you add some tests? I don't think this will get merged without tests. |
I could not find tests around this behavior so I wasn't sure what to write. Where would these tests go? Application or Container? On Jan 6, 2013, at 7:31 AM, Trek Glowacki notifications@github.com wrote:
|
This would be so sweet, +1 |
Do we really want this? App.Users is not a real namespace in sens of Ember (we do not support nested namespaces). When people will se this, they will try App.Models.User, and it will not work because Models can not be a namespace and |
👎 |
Then I guess the real question is why doesn't Ember support nested namespaces (in the Javascript sense, not Ember namespaces)? On Jan 7, 2013, at 6:02 PM, Paul Chavard notifications@github.com wrote:
|
We have other plans for nested namespaces. We'll revisit this once the dust settles from all the current router changes. |
Cool, thanks @wycats. The whole "Ember namespaces are not real namespaces" thing is fairly confusing, so I'm looking forward to seeing what you come up with. |
This enables us to reference namespaced routes using the new routing syntax. So we can support all of:
App.IndexRoute => match("/").to("index")
App.Users.IndexRoute => match("/users").to("users/index")