Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Added examples for arrayContent[Will|Did]Change #18306

Merged
merged 2 commits into from
Sep 1, 2019

Conversation

mukilane
Copy link
Contributor

For #18228

I've added a basic example for both arrayContentWillChange & arrayContentDidChange.

I've also added some twiddles to support them.
arrayContentWillChange and arrayContentDidChange

Would love to have some inputs on how to improve them.

Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some remarks inline, thanks for the help!

packages/@ember/-internals/runtime/lib/mixins/array.js Outdated Show resolved Hide resolved
packages/@ember/-internals/runtime/lib/mixins/array.js Outdated Show resolved Hide resolved
packages/@ember/-internals/runtime/lib/mixins/array.js Outdated Show resolved Hide resolved
packages/@ember/-internals/runtime/lib/mixins/array.js Outdated Show resolved Hide resolved
@mukilane
Copy link
Contributor Author

@locks , I've updated them.

@mukilane
Copy link
Contributor Author

@locks Is any more changes required ?

@locks locks self-assigned this Sep 1, 2019
Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, let's get it in!

@locks locks merged commit 88bc7a4 into emberjs:master Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants