Make escapeExpression public

[sandstrom]

This is a sibling method to htmlSafe. It's currently not available under the module import scheme.

It has historically been provided under Handlebars.Utils.escapeExpression.

A few open questions:

• This is not a re-export from handlebars, it's implemented in the Ember codebase. But that's also what's been done with htmlSafe[1] so I assume it'll work for this method too.

• Do we want to use the name escapeExpression? I think escape would be better

These files may need updating too:

• https://github.com/emberjs/ember.js/blob/561449b0bb18603d4cf5c74d8b7572a5a89cd38a/packages/%40ember/-internals/glimmer/tests/utils/string-test.js
• https://github.com/emberjs/ember.js/blob/1f08044fbdbbdffc9cc014b43861eeb4a2f4803f/packages/%40ember/-internals/glimmer/tests/integration/content-test.js
• https://github.com/emberjs/ember.js/blob/d96d9aad52e010da977d813f479494397ee53ec6/packages/%40ember/-internals/glimmer/tests/integration/components/curly-components-test.js

Closes #16817

For reference, here is the RFC that moved htmlSafe. It does not mention escapeExpression.

---

[1] https://github.com/emberjs/ember.js/blob/v3.16.1/packages/%40ember/-internals/glimmer/lib/utils/string.ts#L60-L86

[MelSumner]

I'll add this to our next meeting agenda- this might require an RFC.

[MelSumner]

After discussing with the core team today- we've decided to not move forward with this PR because Ember doesn't use it internally, and hasn't for quite some time now- it was always an artifact from Handlebars itself.

The work for the module RFC removed non-Ember re-exports, and authors were advised to import what they need directly from any particular non-Ember module (e.g., rsvp or jQuery). This is still our position.

If you feel like you still have a use case, please submit an RFC.

[sandstrom]

@MelSumner Alright, thanks for the update!

Unless I've missed something, anyone implementing escapeExpression themselves will have to rely on the private API of SafeString (it seems to be private). Was that aspect discussed at the core meeting? I tried to find the meeting notes to read myself, but couldn't.

emberjs/rfcs#603