-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The bool value for testing if parentTemplate was recursive was wrong #1916
Conversation
Now passing true on first run prevents the warning and passing false for subsequent runs triggers the warning.
👍 |
The bool value for testing if parentTemplate was recursive was wrong
After updating to RC1, I'm seeing this error throughout my application, though everything is working as expected. Can anyone point me in the right direction for figuring out how to suppress this warning? Not sure where to add an |
You will see the warning when a routes parent did not render in the the default 'main' outlet. In that case, the route has to look to its parents parent to find a template to render into. To surpress the warning, define the the |
Thanks for your response @joeytrapp! I don't mean to be going against the conventional rendering chain. Here's a very simple jsfiddle demonstrating the warning (I get it twice!): http://fiddle.jshell.net/rp97D/1/ Just click 'Run' and then 'Edit' in the result window. If you have your console open, you should see two warnings. I'm assuming I'm not creating/nesting my routes in a conventional way? Any advice would be greatly appreciated. |
@ChrisMCC In the case of your fiddle, the To get the same functionality without the warnings, add an application template and a |
Thank you so much @joeytrapp! You've been very helpful. The warnings are now gone and I feel like I have a better understanding of Ember. Much appreciated. |
My 2 cents on this, after seeing this for a while. And I might be wrong as I don't understand things and their side effects in general. Don't think these warnings are actually useful. There should be a debug flag instead which prints out this info instead. Almost 90% of my use cases render things into a non immediate parent. This is common default/fallback logic ... similar to how events propagate from views > controllers > routes. |
Now passing true on first run prevents the warning and passing false for
subsequent runs triggers the warning.