Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Math.sign for spaceship function implementation #20059

Merged
merged 2 commits into from May 16, 2022
Merged

use Math.sign for spaceship function implementation #20059

merged 2 commits into from May 16, 2022

Conversation

locks
Copy link
Contributor

@locks locks commented Apr 15, 2022

Closes #19988.

@locks locks requested a review from chriskrycho April 15, 2022 13:43
chriskrycho
chriskrycho requested changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Needs one tweak!

packages/@ember/-internals/runtime/lib/compare.ts Show resolved Hide resolved
@chriskrycho chriskrycho disabled auto-merge May 16, 2022 22:27
@chriskrycho chriskrycho merged commit 5b8dfc1 into master May 16, 2022
@chriskrycho chriskrycho deleted the replace-spaceship branch May 16, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskrycho chriskrycho chriskrycho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace internal "spaceship" function with Math.sign
2 participants
@locks @chriskrycho