Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create public import for uniqueId helper #20171

Closed
wants to merge 8 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/@ember/-internals/glimmer/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -324,3 +324,4 @@ export {
setComponentManager,
} from './lib/utils/managers';
export { isSerializationFirstNode } from './lib/utils/serialization-first-node-helpers';
export { default as uniqueId } from './lib/helpers/unique-id';
Original file line number Diff line number Diff line change
@@ -1,8 +1,35 @@
import { RenderingTestCase, strip, moduleFor, runTask } from 'internal-test-helpers';
import {
AbstractTestCase,
RenderingTestCase,
strip,
moduleFor,
runTask,
} from 'internal-test-helpers';
import { setProperties } from '@ember/object';
import { uniqueId, invokeHelper } from '@ember/helper';
import { EMBER_UNIQUE_ID_HELPER } from '@ember/canary-features';
import { getValue } from '@glimmer/validator';

if (EMBER_UNIQUE_ID_HELPER) {
moduleFor(
'Helpers test: {{unique-id}} JS',
class JSRenderingTest extends AbstractTestCase {
chriskrycho marked this conversation as resolved.
Show resolved Hide resolved
constructor(assert) {
super(assert);
this.assert = assert;
}
['@test it can be invoked as a JS function']() {
let first = getValue(invokeHelper({}, uniqueId()));
let second = getValue(invokeHelper({}, uniqueId()));

this.assert.notStrictEqual(
first,
second,
`different invocations of uniqueId should produce different values`
);
}
}
);
moduleFor(
'Helpers test: {{unique-id}}',
class extends RenderingTestCase {
Expand Down
2 changes: 2 additions & 0 deletions packages/@ember/helper/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -314,3 +314,5 @@

export { setHelperManager, helperCapabilities as capabilities } from '@glimmer/manager';
export { invokeHelper, hash, array, concat, get, fn } from '@glimmer/runtime';

export { uniqueId } from '@ember/-internals/glimmer';
1 change: 1 addition & 0 deletions packages/ember/tests/reexports_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ let allExports = [
['_hash', '@ember/helper', 'hash'],
['_get', '@ember/helper', 'get'],
['_concat', '@ember/helper', 'concat'],
['_uniqueId', '@ember/helper', 'uniqueId'],

// @ember/object
['Object', '@ember/object', 'default'],
Expand Down