[BUGFIX types] Add missing type declarations in the preview types for @ember/template-compilation #20410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
changed the title
NullVoxPopuli
force-pushed
the
add-ember-template-compilation
branch
from
1e9d934
to
9da91e8
Compare
NullVoxPopuli
commented
Mar 16, 2023
| precompileTemplate(`Hello World`, { strictMode: true, moduleName: 'hello', scope: () => ({}) }); | ||
|
|
||
| // Integration, since this is the primary use case for precompileTemplate | ||
| expectTypeOf(setComponentTemplate(precompileTemplate(`Hello World`), templateOnly())).toBeObject(); |
There was a problem hiding this comment.
is there any value in keeping expectTypeOf here since setComponentTemplate is already tested?
There was a problem hiding this comment.
Seems fine to keep it here as well.
NullVoxPopuli
force-pushed
the
add-ember-template-compilation
branch
from
9da91e8
to
5b680b2
Compare
jamescdavis
reviewed
Mar 16, 2023
chriskrycho
reviewed
Mar 21, 2023
chriskrycho
requested changes
Mar 21, 2023
… @ember/template-compilation
NullVoxPopuli
force-pushed
the
add-ember-template-compilation
branch
from
72cd1e2
to
8d18b07
Compare
|
This is missing the |
|
Is it public api for It's from a different package: https://github.com/emberjs/ember.js/blob/main/packages/%40ember/template-compilation/index.ts#L4 |
|
It is indeed public API, and in fact is recommended by a different public API: We can probably do a backport for the 4.12 LTS types as well stable; it is not relevant for 5.1 and after, where the types are present by way of compiling from course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds types for
@ember/template-compilation