[BUGFIX canary] Restore/deprecate outlet TemplateFactory support
#20577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancancode
force-pushed
the
restore-deprecate-outlet-template-factory
branch
2 times, most recently
from
9b2b615
to
2c528bb
Compare
Fixes #20576 The test is a bit misleading in that, this is not actually restored to support the very old 1.6.0 version of ember-test-helpers. The issue is that while that particular spot of the invalid usage was fixed in 1.6.1, other similarly invalid patterns have popped up in the code since then. However, the old tests was probably a close enough approximation of the general problem. This is not to avoid fixing the actual issue, but it's just that it was very difficult for us to support for a short time, and there may be other code that copied the same invalid pattern elsewhere. See also emberjs/ember-test-helpers#1445
chancancode
force-pushed
the
restore-deprecate-outlet-template-factory
branch
from
2c528bb
to
3384cc1
Compare
| let templateFullName = `template:-undertest-${templateId}`; | ||
| owner.register(templateFullName, template); | ||
|
|
||
| let outletState = { |
There was a problem hiding this comment.
is every property in here needed?
There was a problem hiding this comment.
Yeah, pretty much, the actual thing is typed in TypeScript in the runtime code (it's the interface you commented on last time)
There was a problem hiding this comment.
But also, the point was to replicate the same code in test helpers, which I gather at one point this was probably close to verbatim, and it's still not that far off today
NullVoxPopuli
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20576
The test is a bit misleading in that, this is not actually restored to support the very old 1.6.0 version of ember-test-helpers. The issue is that while that particular spot of the invalid usage was fixed in 1.6.1, other similarly invalid patterns have popped up in the code since then. However, the old tests was probably a close enough approximation of the general problem.
This is not to avoid fixing the actual issue, but it's just that it was very difficult for us to support for a short time, and there may be other code that copied the same invalid pattern elsewhere.
We could probably backport this to all the way up to LTS if we want with minimal effort, since the code I brought back is basically the same as what was previously there, just with the deprecation.
See also emberjs/ember-test-helpers#1445