Reducing internal usage of AMD loader #20582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kategengler do you have an opinion about how to tag this commit? It's internal refactor. |
|
If it is an internal refactor, would you even want it mentioned in the changelog? |
|
No, but I was thinking you rely on these to help with the cherry-picking release process. If it's not important for release, we don't need any label. |
|
Yeah we wouldn't typically backport an internal refactor |
|
[CLEANUP] or [CLEANUP canary] probably? |
…mentation don't use AMD loader to coordinate optional runtime template compiler update Ember reexports legacy bundle linkage move legacy bundle-specific boostrapping out of the esm packages move the weird _Ember reexport logic moving conditional support for compile() move globals template compiler (lol) remove last use of `require` in test suite lint against re-introducing require clarifying conditional usage
ef4
force-pushed
the
internal-coordination
branch
from
f0a9557
to
f679f03
Compare
|
This is ready to go. |
|
(This already got code reviewed in #20581) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This PR is re-opened from #20581. I merged that one prematurely and immediately force-pushed to revert it.)
There are several places where ember-source depends unnecessarily on details of the AMD loader:
optionally loading the ember-testing implementation
optionally loading the runtime template compiler
This PR replaces them with more direct forms of coordination via module-scoped state.
My overarching goal here is to eliminate all usage of require inside the actual ES module packages so they are true ES modules.
In contrast, the traditional ember.js, ember-testing.js, and ember-template-compiler.js bundles will still use require as their implementation to maintain backward compatibility. Where we need to patch over the weirdness of this (from the perspective of actual compliant ES modules), we do so entirely within the build that produces the bundles.
This is a step toward the proposed strict-es-modules optional feature. This implementation cleanup is happening before advancing that RFC because this cleanup is good either way and does not make any public API changes.