[FEATURE] Make deprecations throw when the until for ember-source has passed
#20669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a new `deprecateUntil` that checks whether a deprecation has been removed and throws if it has. This explicitly uses `throw` and not assert so that it will remain in production builds. This function should be used internally in ember-source in place of `deprecate`. - Add utilities `testIf` and `testUnless` to guard tests based on whether a deprecation has been removed. Uses this for the existing deprecation on @ember/routing - Add a query param to tests `overridedeprecationversion` that takes a version to be the current version for removing deprecation purposes - Add a CI build to use the above to test with deprecations broken
kategengler
changed the title
until for ember-source has passeduntil for ember-source has passed
18 tasks
ef4
approved these changes
Mar 26, 2024
|
@kategengler @ef4 I have a question: does this still get stripped correctly in prod build? looking at just the code here, it's not obvious it would – but maybe the code that handles that is out-of-tree somewhere else? |
|
@chancancode No, it does not ... the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deprecateUntilthat checks whether a deprecation has been removed and throws if it has. This explicitly usesthrowand not assert so that it will remain in production builds. This function should be used internally in ember-source in place ofdeprecate.testIfandtestUnlessto guard tests based on whether a deprecation has been removed. Uses this for the existing deprecation on @ember/routingoverridedeprecationversionthat takes a version to be the current version for removing deprecation purposesFor https://rfcs.emberjs.com/id/0830-evolving-embers-major-version-process