Deprecate array prototype extensions #20702
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per RFC848.
This was a bit trickier than I actually expected, here is what I did and failed to do:
EmberENV.EXTEND_PROTOTYPES
is not false. But given that there is some data munging happening here that is turningEXTEND_PROTOTYPES: false
to becomeEXTEND_PROTOTYPES: { Array: false }
, which I was not eager to change, the deprecation is skipped for both of these. I think that is ok?EXTEND_PROTOTYPES
config is evaluated (1st commit)deprecations/index.ts
, so I moved the deprecation call to the latter. Not ideal, but I had no better idea. (2nd commit)expectDeprecation
. Any idea how to add a test here?expectDeprecation
, I addedRAISE_ON_DEPRECATION=false
to the test matrix scenarios that haveEXTEND_PROTOTYPES
to make them be able to actually run. (3rd commit)