Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid parent's implicit index route clobbering child's explicit index. #2337

Merged
merged 1 commit into from
Mar 28, 2013
Merged

Avoid parent's implicit index route clobbering child's explicit index. #2337

merged 1 commit into from
Mar 28, 2013

Conversation

kamal
Copy link
Contributor

@kamal kamal commented Mar 24, 2013

Fixes #2318.

tomdale added a commit that referenced this pull request Mar 28, 2013
@tomdale
Merge pull request #2337 from viki-org/explicit-index
887f789 
Avoid parent's implicit index route clobbering child's explicit index.
@tomdale tomdale merged commit 887f789 into emberjs:master Mar 28, 2013
@kamal kamal deleted the explicit-index branch March 28, 2013 21:08
@kamal kamal mentioned this pull request Mar 29, 2013
Closed
@ElteHupkes
Copy link

I'd like to note that as a side effect of this, using this.route('index') without specifying the {path: '/'} explicitly now fails to find the index route at the / path (because the "backup" route is no longer added). This might be unexpected behavior; should we perhaps automatically set a / path on routes named "index" when no path is specified?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested index route gets overwritten by parent's implicit index route
3 participants
@kamal @ElteHupkes @tomdale