Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed problem with dependentKeys on registerBoundHelper. #3052

Merged
merged 1 commit into from Jul 28, 2013
Merged

Fixed problem with dependentKeys on registerBoundHelper. #3052

merged 1 commit into from Jul 28, 2013

Conversation

arturmalecki
Copy link
Contributor

@wagenet
Copy link
Member

wagenet commented Jul 27, 2013

@seeweer The tests doesn't pass on this.

@stefanpenner
Copy link
Member

If you are having trouble reproducing locally give running tests with bundle exec rake 'test[standard]' a try, as that is what ci runs.

@wagenet wagenet merged commit 0226e1c into emberjs:master Jul 28, 2013
@wagenet
Copy link
Member

wagenet commented Jul 28, 2013

Turns out there was a problem with the general tests that was leaking and causing these failures.

@wagenet
Copy link
Member

wagenet commented Jul 28, 2013

Merged here 234219d. Tests fix here: 98cbd9d.

@wagenet wagenet mentioned this pull request Jul 28, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0 Final
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arturmalecki @wagenet @stefanpenner