[FEATURE ember-testing-wait-hooks] #3433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In integration testing, sometimes it's necessary to make `wait` respect other kinds of pending actions that are not in its default implementation. For example, if your application is waiting for a CSS3 transition or an IndexDB action, the default `wait` implementaiton will ignore those things and move on with the test prematurely. This change lets you register additional functions that `wait` will call to see whether it's really time to move on.
|
👍 Awesome, I've been itching to role this. Thanks bro. |
stefanpenner
added a commit
that referenced
this pull request
Sep 26, 2013
[FEATURE ember-testing-wait-hooks]
ghost
assigned
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In integration testing, sometimes it's necessary to make
waitrespectother kinds of pending actions that are not in its default
implementation. For example, if your application is waiting for a CSS3
transition or an IndexDB action, the default
waitimplementaiton willignore those things and move on with the test prematurely.
This change lets you register additional functions that
waitwill callto see whether it's really time to move on.