[BUGFIX release] Fix Ember.Object.extend for old IE #3508
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In old IE,
Ember.Object.extend
couldn't extend property that is named the same as a property ofObject.prototype
.The cause is that
for ~ in
loop doesn't enumerate a property ofObject.prototype
in old IE.To fix this issue, I fixed
Ember.keys
to return its own properties and I used it forEmber.Object.extend
.