Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember.computed.readOnly #3879

Merged
merged 1 commit into from Dec 8, 2013

Conversation

stefanpenner
Copy link
Member

Basically nearly every time one uses oneWay, one actually
want's to also ensure no data propagates back up. Rather then
constantly using oneWay and readOnly in conjunction, this
merely combines them.

@wagenet
Copy link
Member

wagenet commented Dec 8, 2013

@stefanpenner What's up with this failing test?

@wagenet
Copy link
Member

wagenet commented Dec 8, 2013

This is technically a new feature too, no?

@stefanpenner
Copy link
Member Author

@wagenet it is just barely a new feature. It is in fact merely less punishment for doing the right thing. I can flag it if you wish.

@stefanpenner
Copy link
Member Author

failing test is Ember.inspect is only in runtime. As its only other dependency (typeOf) is also in metal, I am moving it there.

@stefanpenner
Copy link
Member Author

feature flagged!

Basically nearly every time one uses oneWay, one actually
want's to also ensure no data propagates back up. Rather then
constantly using `oneWay` and `readOnly` in conjunction, this
merely combines them.
stefanpenner added a commit that referenced this pull request Dec 8, 2013
@stefanpenner stefanpenner merged commit 43709cd into emberjs:master Dec 8, 2013
@stefanpenner stefanpenner deleted the computed-read-only branch December 8, 2013 05:04
@stefanpenner stefanpenner mentioned this pull request Jan 3, 2014
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants