This repository has been archived by the owner on Nov 11, 2017. It is now read-only.
Added z-index:1 to list-view + brought back transform3d positioning, removes CSS requirements #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orm3d positioning - Moved applyTransform from ListView to ListViewMixin since VirtualListView also uses it. - Brought transform3d based positioning back into applyTransform - Added z-index:1 to ListView in order to fix scroll-bar layering on webkit - Added position:absolute to ListItemViewMixin to remove CSS requirements - Removed ListViewHelper (no longer needed) - All tests seem to pass Note: This does not fix emberjs#48 (inertial scrolling conflict with mouse events on webkit).
minusfive
referenced
this pull request
Jun 5, 2013
delegate applyTransform from list item to parent and always use top left in ListView to prevent scroll bar from being occluded.
|
So please hold on this. We've been discussing with @kselden and a few changes need to be made here. Will update asap. |
|
status? |
|
@stefanpenner transform2d provided the perf without the bug was the conclusion of our discusion |
|
@minusfive would u like to make the adjustments, if you are to busy me or @kselden can jump on it. |
|
Yeah, I'm terribly sorry guys, the project I've been working on has been ramping up for launch, so I've been busier than anticipated. Haven't had a chance to continue work on this. Please move forward without me, and thank you so much for your work. |
ghost
assigned
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54
also uses it.
Note: This does not fix #48 (inertial scrolling conflict with mouse events
on webkit).