Merge branch 'master' into advance-rfc-0726

.github/PULL_REQUEST_TEMPLATE/advance-to-ready-for-release.md

@@ -31,6 +31,8 @@ Each Ember core team will be requested as a reviewer on the PR to move into this
 - [ ] Implementation is complete according to plan outlined in the RFC, with any adjustments noted in the RFC
 - [ ] Any necessary learning materials have been updated
 - [ ] The Ember team is ready to commit to the stability of any interfaces exposed by the current implementation of the feature. This is the go/no go decision for any feature flags, but the flags should only be turned on when moving to Released.
+- [ ] The feature may not yet have support by the entire ecosystem (e.g. IDEs, addons, Ember Inspector, Engines, Lint Rules, Blueprints, etc), but it does not unintentionally break any existing functionality in those areas.
+- [ ] The Interactive Tutorial is not broken by this feature.
 - [ ] Criteria for moving to the Recommended Stage has been filled out
 - [ ] This PR has been converted from a draft to a regular PR and the `Final Comment Period` label has been added to start the FCP
 - [ ] Each [team](https://github.com/emberjs/rfcs#relevant-teams) has been added as a reviewer to the PR at the start of the FCP. Reviews are not required by the end of the FCP. This is a notification step.

.github/PULL_REQUEST_TEMPLATE/advance-to-recommended.md

@@ -37,13 +37,21 @@ An FCP is required to enter this stage. Multiple RFCs may be moved as a batch in
 
 ## Checklist to move to Recommended
 
-- [ ] Any criteria for "Recommended" for this proposal that were established in the Ready For Release stage have been met
-- [ ] If appropriate, the feature is integrated into the tutorial and the guides prose. API documentation is polished and updates are carried through to other areas of API docs that may not directly pertain to the feature.
-- [ ] If the proposal replaces an existing feature, the addon ecosystem has largely updated to work with both old and new features.
-- [ ] If the proposal updates or replaces an existing feature, high-quality codemods are available
-- [ ] If needed, Ember debugging tools as well as popular IDE support have been updated to support the feature.
-- [ ] If the feature is part of a suite of features that were designed to work together for best ergonomics, the other features are also ready to be "Recommended".
-- [ ] This PR has been converted from a draft to a regular PR and the `Final Comment Period` label has been added to start the FCP
+- [ ] **Criteria specific to this feature:** Any additional criteria for "Recommended" for this proposal that were established in the Ready For Release stage have been met.
+- [ ] **Tutorial:** If appropriate, the feature is integrated into the tutorial.
+- [ ] **Guides:** If appropriate, the feature is integrated into the guides prose. 
+- [ ] **API Docs:** API documentation is polished and updates are carried through to other areas of API docs that may not directly pertain to the feature.
+- [ ] **Addon Ecosystem:** If the proposal replaces an existing feature, the addon ecosystem has largely updated to work with both old and new features.
+- [ ] **Codemods:** If the proposal updates or replaces an existing feature, high-quality codemods are available.
+- [ ] **Debugging Tools:** If needed, Ember debugging tools (e.g. Ember Inspector, Deprecation Workflow) have been updated to support the feature.
+- [ ] **IDE Support:** If needed, popular IDE support has been updated to support the feature.
+- [ ] **Engines, SSR:** If needed, ecosystem feature such as Ember Engines, SSR support have been updated to support the feature.
+- [ ] **Blueprints:** Blueprints have been updated to support the feature and to reflect the new best practices implied by this feature.
+- [ ] **Linting:** Lint rules have been updated or added or removed to support the feature and to reflect the new best practices implied by this feature.
+- [ ] **Deprecations:** If this feature implies that other features are no longer best practice, RFCs have been created to deprecate those features.
+- [ ] **Blog Post:** Consider if a blog post should be written to introduce this feature to the community.
+- [ ] **Feature Suite:** If the feature is part of a suite of features that were designed to work together for best ergonomics, the other features are also ready to be "Recommended".
+- [ ] **FCP to Recommended:** This PR has been converted from a draft to a regular PR and the `Final Comment Period` label has been added to start the FCP.
 
 ## Criteria for moving to Recommended (required)
 

0000-template.md

@@ -30,7 +30,8 @@ project-link: Leave as is
 suite: Leave as is
 -->
 
-# <RFC title>
+<-- Replace "RFC title" with the title of your RFC -->
+# RFC title
 
 ## Summary
 
@@ -49,7 +50,17 @@ outcome?
 familiar with the framework to understand, and for somebody familiar with the
 implementation to implement. This should get into specifics and corner-cases,
 and include examples of how the feature is used. Any new terminology should be
-defined here.
+defined here. 
+
+> Please keep in mind any implications within the Ember ecosystem, such as:
+> - Lint rules (ember-template-lint, eslint-plugin-ember) that should be added, modified or removed
+> - Features that are replaced or made obsolete by this feature and should eventually be deprecated
+> - Ember Inspector and debuggability
+> - Server-side Rendering
+> - Ember Engines
+> - The Addon Ecosystem
+> - IDE Support
+> - Blueprints that should be added or modified
 
 ## How we teach this
 
@@ -64,6 +75,8 @@ at any level?
 > How should this feature be introduced and taught to existing Ember
 users?
 
+> Keep in mind the variety of learning materials: API docs, guides, blog posts, tutorials, etc.
+
 ## Drawbacks
 
 > Why should we *not* do this? Please consider the impact on teaching Ember,

deprecation-template.md

@@ -28,7 +28,8 @@ prs:
 project-link: Leave as is
 -->
 
-# <RFC title>
+<-- Replace "RFC title" with the title of your RFC -->
+# RFC Title 
 
 ## Summary
 
@@ -47,6 +48,19 @@ Describe it in enough detail for someone who uses the deprecated functionality
 to understand, for someone to write the deprecation guide, and for someone
 familiar with the implementation to implement.
 
+> It can be helpful to write the deprecation guide as part of this section. Published deprecation
+> guides can be found at https://deprecations.emberjs.com/.
+
+> Please keep in mind any implications within the Ember ecosystem, such as:
+> - Lint rules (ember-template-lint, eslint-plugin-ember) that should be added, modified or removed
+> - Features that are replaced or made obsolete by this feature and should eventually be deprecated
+> - Ember Inspector and debuggability
+> - Server-side Rendering
+> - Ember Engines
+> - The Addon Ecosystem
+> - IDE Support
+> - Blueprints that should be added or modified
+
 ## How We Teach This
 
 > Would the acceptance of this proposal mean the Ember guides must be
@@ -58,6 +72,8 @@ related to this feature?
 How should this deprecation be introduced and explained to existing Ember
 users?
 
+> Keep in mind the variety of learning materials: API docs, guides, blog posts, tutorials, etc.
+
 ## Drawbacks
 
 > Why should we *not* do this? Please consider the impact on teaching Ember,

text/0659-unique-id-helper.md

@@ -1,14 +1,14 @@
 ---
-stage: released # FIXME: This may be recommended
+stage: recommended
 start-date: 2020-08-25T00:00:00.000Z
 release-date: 2022-05-02T00:00:00.000Z
 release-versions:
   ember-source: v4.4.0
-
 teams:
   - framework
 prs:
-  accepted: https://github.com/emberjs/rfcs/pull/659
+  accepted: 'https://github.com/emberjs/rfcs/pull/659'
+  recommended: 'https://github.com/emberjs/rfcs/pull/865'
 project-link:
 ---
 

text/0776-typescript-blueprints.md

@@ -1,5 +1,5 @@
 ---
-stage: released
+stage: recommended
 start-date: 2021-11-11T00:00:00.000Z
 release-date: 2022-12-08T00:00:00.000Z
 release-versions:
@@ -12,6 +12,7 @@ prs:
   accepted: 'https://github.com/emberjs/rfcs/pull/776'
   ready-for-release: 'https://github.com/emberjs/rfcs/pull/873'
   released: 'https://github.com/emberjs/rfcs/pull/911'
+  recommended: 'https://github.com/emberjs/rfcs/pull/912'
 project-link:
 ---
 

text/0811-element-modifiers.md

@@ -1,5 +1,5 @@
 ---
-stage: released
+stage: recommended
 start-date: 2022-03-29T00:00:00.000Z
 release-date: 2023-03-03T00:00:00.000Z
 release-versions:
@@ -11,6 +11,7 @@ prs:
   accepted: 'https://github.com/emberjs/rfcs/pull/811'
   ready-for-release: 'https://github.com/emberjs/rfcs/pull/885'
   released: 'https://github.com/emberjs/rfcs/pull/928'
+  recommended: 'https://github.com/emberjs/rfcs/pull/934'
 project-link:
 ---
 

text/0918-deprecate-travis-ci-support.md

@@ -1,14 +1,17 @@
 ---
-stage: ready-for-release
+stage: recommended
 start-date: 2023-03-25T00:00:00.000Z
-release-date:
+release-date: 2023-12-11T00:00:00.000Z
 release-versions:
+  ember-cli: 5.5.0
 teams:
   - cli
   - learning
 prs:
   accepted: 'https://github.com/emberjs/rfcs/pull/918'
   ready-for-release: 'https://github.com/emberjs/rfcs/pull/954'
+  released: 'https://github.com/emberjs/rfcs/pull/978'
+  recommended: 'https://github.com/emberjs/rfcs/pull/994'
 project-link:
 ---