Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hash built-in in strict-mode #999

Merged
merged 7 commits into from
Jun 12, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 70 additions & 0 deletions text/0999-make-hash-built-in.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
---
stage: accepted
start-date: 2023-12-22T00:00:00.000Z
release-date: # In format YYYY-MM-DDT00:00:00.000Z
release-versions:
teams: # delete teams that aren't relevant
- framework
- learning
- typescript
prs:
accepted: https://github.com/emberjs/rfcs/pull/0999
project-link:
suite:
---

<!---
Directions for above:

stage: Leave as is
start-date: Fill in with today's date, 2032-12-01T00:00:00.000Z
release-date: Leave as is
release-versions: Leave as is
teams: Include only the [team(s)](README.md#relevant-teams) for which this RFC applies
prs:
accepted: Fill this in with the URL for the Proposal RFC PR
project-link: Leave as is
suite: Leave as is
-->

# Make `(hash)` a built in helper

## Summary

Today, when using gjs/gts/`<template>`, in order to make objects in a template, folks _must import_ the `(hash)` helper.
Because creating objects is fairly commonplace, this is an annoyance for developers, especially as almost every other language has object literal syntax.

This RFC proposes that `(hash)` be built in to `glimmer-vm` and not require importing.

## Motivation

Arrays and Objects are not only very common to create, they are essential tools when yielding data out of components.

There is alternate motivation to implement _literals_ for arrays and objects, but that is a bigger can of worms for another time.

## Detailed design

This change would affect strict-mode only. This is so that today's existing code that imports `hash` from `@ember/helper` will still work due to how values defined locally in scope override globals.

The behavior of `hash` would be the same as it is today, but defined by default in the `glimmer-vm`.

Being built in can give folks confidence that each property in the hash is individually reactive.

## How we teach this

Once implemented, the guides, if they say anything about gjs/gts/`<template>` and `hash` by the time this would be implemented, would only remove the import.
NullVoxPopuli marked this conversation as resolved.
Show resolved Hide resolved

The guides should also detail which functions are built in to the framework and, therefore, do not need to be imported.

## Drawbacks

People may not know where `hash` is defined.
- counterpoint: do they need to?

## Alternatives

n/a

## Unresolved questions

n/a
Loading