Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for module unification folder #43

Closed
wants to merge 9 commits into from

Conversation

hakubo
Copy link
Contributor

@hakubo hakubo commented Jul 5, 2018

No description provided.

@samselikoff
Copy link
Contributor

Thank you!

Could we get a new test added here?

@hakubo
Copy link
Contributor Author

hakubo commented Jul 6, 2018

will do next week,
also - not sure if that works :)
so give me couple of more days to finish that

@hakubo hakubo closed this Jul 6, 2018
@hakubo hakubo reopened this Jul 6, 2018
@hakubo
Copy link
Contributor Author

hakubo commented Jul 10, 2018

@samselikoff turns out much more is needed to support MU layout
I have gone to the point that tests run
everything should be fine

but actual thing that we're trying to do here is not working
could you have a look and point me in the right direction?

since this needs master of ember-cli to run now - probably you won't be merging that soon
but I'd like to test drive it in my side project so I'd be glad to get some help with it

@willviles
Copy link

It'd be great to get this addon working with module unification. I believe these are the issues:

treeForStyles isn't used by module unification apps. Instead, everything is merged together via app.trees.src. See ember-cli/ember-cli#7862.

However, at the moment there's a blocking issue with merging trees into app.trees.src, caused by a validation error with Ember CLI ESLint: ember-cli/ember-cli-eslint#56.

@samselikoff
Copy link
Contributor

@willviles are y'all using MU today? It was my understanding that much could change about MU before it gets shipped and I'm a little hesitant to add a bunch of code to ec-tailwind to support an unstable feature...

Happy to do it if it makes sense though

@willviles
Copy link

I'm not migrating our production apps to MU yet as compatibility with addons is clearly sketchy. However, I'm testing out a small static marketing site with module unification and reporting problems as I go.

I'll dig a little deeper and find out whether there's a stable path for addons to support MU and what's blocking that from happening 👍

@samselikoff
Copy link
Contributor

Awesome, thank you very much & looking forward to what you find. (Latest thing I saw that made me hesitant was this comment, perhaps Robert + crew have more information.)

@willviles
Copy link

Sure - I think that particular comment was relating to a separate RFC titled Module Unification Namespaces and specifically the use of the new {{use}} helper, rather than the accepted and well rationalized Module Unification RFC.

Albeit there's still a fair bit left to be implemented in the quest issue for MU!

@samselikoff
Copy link
Contributor

I see – then yes we should support it. Seems like it's come up a few times

gossi added a commit to gossi/ember-cli-tailwind that referenced this pull request Aug 11, 2018
@gossi gossi mentioned this pull request Aug 11, 2018
4 tasks
@hakubo hakubo closed this Dec 17, 2018
@hakubo
Copy link
Contributor Author

hakubo commented Dec 17, 2018

Thanks @gossi for pushing this foraward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants